Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly (#11042) #11083

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11042

What problem does this PR solve?

Issue Number: close #10998

What is changed and how it works?

When changefeed state has changed, reacquiring changefeed-error-stuck-duration. feedStateManager checks for new value about changefeedErrorStuckDuration every feedStateManager.Tick call so that it can sense the updated value.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    1. start a CDC server
    2. run script
    bin/cdc cli changefeed create -c test --sink-uri "kafka://127.0.0.1:9092/test?topic=test&protocol=open-protocol&max-message-bytes=41943040&compressionType=ZLIB" --changefeed-id="test"
    bin/cdc cli changefeed pause --changefeed-id="test"
    bin/cdc cli changefeed update --changefeed-id="test" --config=changefeed.toml
    bin/cdc cli changefeed resume --changefeed-id="test"
    changefeed.toml
     changefeed-error-stuck-duration = "1h30m"
    1. check CDC log
    Screenshot 2024-05-11 at 17 05 18

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 13, 2024
@wk989898
Copy link
Collaborator

/retest

@wk989898
Copy link
Collaborator

Manual test pass

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 14, 2024
@wk989898
Copy link
Collaborator

/retest

1 similar comment
@wk989898
Copy link
Collaborator

/retest

Copy link
Contributor

ti-chi-bot bot commented May 15, 2024

@wk989898: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4e0955b into pingcap:release-7.5 May 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants